CallTileTimelineItem.CallStatus.MISSED renders both missed and reject… #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed calls. Logic should be !answered.
bmarty
approved these changes
Jan 28, 2022
| @@ -101,7 +101,7 @@ class CallItemFactory @Inject constructor( | |||
| createCallTileTimelineItem( | |||
| roomSummary = roomSummary, | |||
| callId = callEventGrouper.callId, | |||
| callStatus = if (callEventGrouper.callWasMissed()) CallTileTimelineItem.CallStatus.MISSED else CallTileTimelineItem.CallStatus.ENDED, | |||
| callStatus = if (!callEventGrouper.callWasAnswered()) CallTileTimelineItem.CallStatus.MISSED else CallTileTimelineItem.CallStatus.ENDED, | |||
There was a problem hiding this comment.
Can I ask you to remove ! and swap if and else blocks to simplify reading?
There was a problem hiding this comment.
was about to say the same thing 😄
There was a problem hiding this comment.
:). also the CI complains that the line is too long
Matrix SDKIntegration Tests Results:
|
bmarty
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5088
The if statement switches between
CallStatus.MISSEDandCallStatus.ENDED.CallStatus.MISSEDrenders both missed calls and not answered calls. So i think the logic makes more sense to check that the call was not answered vs the old code which checks all events are from one side.